patch-2.1.131 linux/drivers/char/tty_io.c

• Lines: 15
• Date: Fri Nov 27 10:24:27 1998
• Orig file: v2.1.130/linux/drivers/char/tty_io.c
• Orig date: Fri Nov 27 13:09:23 1998

diff -u --recursive --new-file v2.1.130/linux/drivers/char/tty_io.c linux/drivers/char/tty_io.c
@@ -868,7 +868,13 @@
 	 * Failures after this point use release_mem to clean up, so 
 	 * there's no need to null out the local pointers.
 	 */
-	driver->table[idx] = tty;
+	driver->table[idx] = tty;	/* FIXME: this is broken and
+	probably causes ^D bug. tty->private_date does not (yet) point
+	to a console, if keypress comes now, await armagedon. 
+
+	also, driver->table is accessed from interrupt for vt case,
+	and this does not look like atomic access at all. */
+	
 	if (!*tp_loc)
 		*tp_loc = tp;
 	if (!*ltp_loc)